FishEye and Crucible

Thanks for setting up, please let me know how helpful you find the process and we can make a recommendations about how to use crucible in other parts of the project, but for now don't get to distracted from your task list.

How about a link to the DAP protocol?

The IStore interface is reasonable. I think it is the right choice to use the maybeDeferred wrapper function, especially if we are making a synchronous call. When we use the in memory key value store, the operations on the underlying dictionary should be synchronous.

Now that we have a copy saved in local /tmp, it it worthwhile to diff against the original?

It's pretty unusual to have multiple triple-quotes inside a single function. There is usual one and only one, and that one defines the function's docstring. I say this with the experience of looking at a lot of other "large/popular" python libs, no because it's "against the rules" or whatever.

It'd be a bit more readable to use the
from zope.interface import Interface, implements, Attribute

I saw this defined in the CAS code as well. Perhaps a common file?

Debug code?

Move to unit tests.

Why the empty test? Unfinished or deliberate?

Lots of pyflakes warnings on the code right now -

pyflakes ion | grep objstore
ion/data/datastore/objstore.py:430: local variable 'tree_id' is assigned to but never used
ion/data/datastore/objstore.py:437: local variable 'objectClassName' is assigned to but never used
ion/data/datastore/objstore.py:449: local variable 'id' is assigned to but never used
ion/data/datastore/objstore.py:547: local variable 'ind2' is assigned to but never used
ion/data/datastore/objstore.py:556: local variable 'obj' is assigned to but never used
ion/data/datastore/rdfstore.py:17: 'objstore' imported but unused
ion/data/datastore/test/test_objstore.py:36: local variable 'object_store2' is assigned to but never used
ion/data/datastore/test/test_objstore.py:48: local variable 'object_store2' is assigned to but never used
ion/data/datastore/test/test_rdfstore.py:18: 'objstore' imported but unused
ion/play/objstore/git.py:110: undefined name 'objstore'
ion/play/objstore/git.py:134: undefined name 'objstore'

Should probably have a bit more file header - #!env plus usual doxygen metadata.

Lots of empty doc strings.

What does this accomplish? Are you expecting an exception? Is there any way to validate the output?

Third definition I've seen of this today...

pyflakes complains of unused imports

On the client side, a docstring explaining how to use it? What's a resource? What isn't? Who should use this?

Should this be self.failUnlessEqual? Not sure what assertFalse does with two arguments.

How does this differ from get_service_instance?

Worth a docstring to note that this is the base class for the tests further down the file.

Will do.

This method body is too long. Refactor it into smaller methods. The routines that add properties and add associations can be made their own methods.
A Pythonic way of doing this is to use a leading underscore to indicate that they are supposed to be private methods.

Good job.

Please add concise and descriptive docstrings to the classes. This provides the necessary summary view for people to understand this module.
Think of it as a marketing task.

I think a few of the methods should be refactored into smaller methods.

I'm not sure why you use classmethod for load and reference. I know you might want to use it for create as this follows
a factory pattern. There could be a good reason to use it for load and reference, but I don't know it.

Nice use of asserts. This is a good programming practice.